Adding USD_2022 to units library as the most recently published value#1413
Adding USD_2022 to units library as the most recently published value#1413andrewlee94 merged 1 commit intoIDAES:mainfrom
Conversation
|
Note the conversion value for USD_2021 in the repo differs from the one published in https://toweringskills.com/financial-analysis/cost-indices/ (708.0 compared to 708.8). I imagine changing this value in the repo would require a lot of downstream changes in value assertions for costing tests, so I'm leaving as is. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 77.89% 77.89% -0.01%
==========================================
Files 394 394
Lines 65079 65079
Branches 14389 14389
==========================================
- Hits 50695 50692 -3
- Misses 11795 11799 +4
+ Partials 2589 2588 -1 ☔ View full report in Codecov by Sentry. |
bpaul4
left a comment
There was a problem hiding this comment.
@hunterbarber thank you for adding the 2022 value. We actually use 2018 as the default for most tests, so updating the 2021 value should have a small impact. Please feel free to update this value.
|
@hunterbarber @bpaul4 We need to be careful about changing values like this; whilst we might not test against it, others might be using the values and this would be an unexpected change for them. If there is good cause for the change then we can consider it, but we would also need to discuss backward compatibility. |
Fixes
Append USD_YYYY list with USD_2022 value from https://toweringskills.com/financial-analysis/cost-indices/
Summary/Motivation:
Add more up to date values for USD
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: