Merged
Conversation
andrewlee94
requested review from
Robbybp,
bpaul4,
dallan-keylogic,
ksbeattie,
lbianchi-lbl and
rundxdi
as code owners
andrewlee94
added
Priority:High
bpaul4
approved these changes
May 6, 2024
Contributor
bpaul4
left a comment
bpaul4
left a comment
There was a problem hiding this comment.
Looks fine to me, pending the tests passing once the branch is updated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 77.89% 77.88% -0.01%
==========================================
Files 394 394
Lines 65061 65053 -8
Branches 14383 14383
==========================================
- Hits 50678 50667 -11
- Misses 11793 11797 +4
+ Partials 2590 2589 -1 ☔ View full report in Codecov by Sentry. |
This was referenced May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Pyomo/pyomo#3221
Requires a fix in Pyomo and/or OMLT to address exception due to sub-classing metaclass. Will also require the Pyomo dependency to be updated.
Summary/Motivation:
This PR updates IDAES to use the new public names for Pyomo component data classes.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: