Adding attributes to hold units used by MSContactor#1396
Merged
andrewlee94 merged 2 commits intoIDAES:mainfrom Apr 16, 2024
Merged
Adding attributes to hold units used by MSContactor#1396andrewlee94 merged 2 commits intoIDAES:mainfrom
andrewlee94 merged 2 commits intoIDAES:mainfrom
Conversation
andrewlee94
added
enhancement
Contributor
|
@andrewlee94 it looks like many tests directly call |
Contributor
Author
|
@bpaul4 No - I just didn't think I'd need to update the tests. |
bpaul4
approved these changes
Apr 15, 2024
agarciadiego
approved these changes
Apr 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
- Coverage 77.63% 77.62% -0.01%
==========================================
Files 391 391
Lines 64392 64391 -1
Branches 14264 14264
==========================================
- Hits 49990 49986 -4
- Misses 11830 11834 +4
+ Partials 2572 2571 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes None
Summary/Motivation:
For unit models deriving from the MSContactor, or using it a a building block, it is often necessary to know the units of measurement used for the unit model variables. This PR gets the MSContactor to store these as attributes so that deriving models can make use of them.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: