Resolve CI failures from new version (1.20.4) of spellchecker#1389
Resolve CI failures from new version (1.20.4) of spellchecker#1389lbianchi-lbl merged 6 commits intoIDAES:mainfrom
Conversation
lbianchi-lbl
requested review from
MAZamarripa,
andrewlee94,
bpaul4,
dallan-keylogic and
dangunter
as code owners
lbianchi-lbl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
- Coverage 77.62% 77.62% -0.01%
==========================================
Files 391 391
Lines 64375 64375
Branches 14257 14257
==========================================
- Hits 49973 49970 -3
- Misses 11830 11834 +4
+ Partials 2572 2571 -1 ☔ View full report in Codecov by Sentry. |
.github/workflows/typos.toml
Outdated
| hd = "hd" | ||
| Tge = "Tge" | ||
| iy = "iy" | ||
| frst = "frst" # variable name in idaes/core/util/model_serializer.py No newline at end of file |
There was a problem hiding this comment.
This seems risky to me, as "frst" could be a common typo of "first" and wouldn't be caught. Would changing the name to "first" raise any issues or difficulties elsewhere in the codebase?
idaes-pse/idaes/core/util/model_serializer.py
Line 607 in 8948c6c
There was a problem hiding this comment.
This is an excellent point, thanks. As it's a local variable, I think we can change frst in the code and remove it from the list of known false positives.
There was a problem hiding this comment.
For what it's worth, I changed ws in some of our code due to it being a common misspelling of was. This is likely a good idea to change.
lbianchi-lbl
changed the title
* Resolve CI failures from new version (1.20.4) of spellchecker (#1389) * Empty commit to verify failures on main * Resolve likely false positives * Resolve likely true positives * Resolve probable true positive * Remove "frst" from typos exclusions * Remove "ans" from typos exclusions b/c crate-ci/typos#981 * Fix target for 'fv' (flowsheet visualizer) reference (#1391) * outputs * fix hyperlink * put this back * put this back2 * replace with simple hyperlink * Updating black and rerunning it on all files (#1388) * Updating black and rerunning it on all files * Remove duplicated Black requirement * Update Black rev in pre-commit config --------- Co-authored-by: Ludovico Bianchi <[email protected]> --------- Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: Dan Gunter <[email protected]> Co-authored-by: Keith Beattie <[email protected]>
4 participants
Fixes
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: