Updating black and rerunning it on all files#1388
Merged
lbianchi-lbl merged 4 commits intoIDAES:mainfrom Apr 4, 2024
Merged
Conversation
ksbeattie
requested review from
AlexNoring,
MAZamarripa,
Robbybp,
adowling2,
agarciadiego,
andrewlee94,
aostace01,
bpaul4,
dallan-keylogic,
dangunter,
jsiirola,
lbianchi-lbl and
rundxdi
as code owners
Member
Author
|
@lbianchi-lbl, why is black in |
Contributor
Thanks for spotting that, I don't think there's any reason. I pushed a commit to remove the duplicated requirement, and another to update the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
- Coverage 77.62% 77.62% -0.01%
==========================================
Files 391 391
Lines 64375 64375
Branches 14257 14257
==========================================
- Hits 49973 49970 -3
- Misses 11830 11834 +4
+ Partials 2572 2571 -1 ☔ View full report in Codecov by Sentry. |
bpaul4
approved these changes
Apr 1, 2024
Contributor
bpaul4
left a comment
bpaul4
left a comment
There was a problem hiding this comment.
For the most part the formatting looks much cleaner now, I like that small expressions are consolidated into one or two lines instead of spaced out like before.
andrewlee94
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Resolve CI failures from new version (1.20.4) of spellchecker (#1389) * Empty commit to verify failures on main * Resolve likely false positives * Resolve likely true positives * Resolve probable true positive * Remove "frst" from typos exclusions * Remove "ans" from typos exclusions b/c crate-ci/typos#981 * Fix target for 'fv' (flowsheet visualizer) reference (#1391) * outputs * fix hyperlink * put this back * put this back2 * replace with simple hyperlink * Updating black and rerunning it on all files (#1388) * Updating black and rerunning it on all files * Remove duplicated Black requirement * Update Black rev in pre-commit config --------- Co-authored-by: Ludovico Bianchi <[email protected]> --------- Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: Dan Gunter <[email protected]> Co-authored-by: Keith Beattie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Replaces dependabot alert about black: #1381
Summary/Motivation:
Guess it's time to run this again
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: