Skip to content

Comments

Add constraint to exclude TensorFlow 2.16.1 and above#1373

Merged
lbianchi-lbl merged 1 commit intoIDAES:mainfrom
lbianchi-lbl:tensorflow-2.16.1
Mar 12, 2024
Merged

Add constraint to exclude TensorFlow 2.16.1 and above#1373
lbianchi-lbl merged 1 commit intoIDAES:mainfrom
lbianchi-lbl:tensorflow-2.16.1

Conversation

@lbianchi-lbl
Copy link
Contributor

Summary/Motivation:

Workaround for the new version of TensorFlow that's causing #1369

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl requested a review from ksbeattie as a code owner March 12, 2024 16:27
Copy link
Contributor

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good until we can address the compatibility issues.

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Mar 12, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Mar 12, 2024
@codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (2f34dd3) to head (a12faea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.01%     
==========================================
  Files         391      391              
  Lines       64330    64330              
  Branches    14244    14244              
==========================================
- Hits        49923    49920       -3     
- Misses      11831    11835       +4     
+ Partials     2576     2575       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl added dependencies Pull requests that update a dependency file Priority:High High Priority Issue or PR CI:run-integration triggers_workflow: Integration labels Mar 12, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Mar 12, 2024
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Mar 12, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Mar 12, 2024
@lbianchi-lbl lbianchi-lbl merged commit fc1a7da into IDAES:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants