Skip to content

BUGFIX: New version of crate-ci/typos#1204

Merged
lbianchi-lbl merged 1 commit intoIDAES:mainfrom
mrmundt:typos-update
Jun 10, 2023
Merged

BUGFIX: New version of crate-ci/typos#1204
lbianchi-lbl merged 1 commit intoIDAES:mainfrom
mrmundt:typos-update

Conversation

@mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Jun 9, 2023

Fixes #1203

Summary/Motivation:

There was a new version of the crate-ci/typos action released yesterday that caught new typos.

Changes proposed in this PR:

  • Correct newly caught typos
  • Add a few correctly spelled words to typos.toml

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt changed the title New version of typos tool; fixing previously missed typos BUGFIX: New version of crate-ci/typos Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (73a51b7) 76.83% compared to head (182a632) 76.82%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
- Coverage   76.83%   76.82%   -0.01%     
==========================================
  Files         390      390              
  Lines       61852    61852              
  Branches    11386    11386              
==========================================
- Hits        47523    47520       -3     
- Misses      11867    11871       +4     
+ Partials     2462     2461       -1
Impacted Files Coverage Δ
idaes/apps/grid_integration/bidder.py 96.61% <ø> (ø)
idaes/core/base/control_volume1d.py 90.18% <ø> (ø)
idaes/core/base/costing_base.py 89.16% <ø> (ø)
idaes/models_extra/column_models/condenser.py 89.06% <ø> (ø)
...models_extra/column_models/plate_heat_exchanger.py 93.79% <ø> (ø)
idaes/models_extra/column_models/reboiler.py 87.38% <ø> (ø)
idaes/models_extra/column_models/tray.py 92.20% <ø> (ø)
...s/subcritical_power_plant/steam_cycle_flowsheet.py 62.33% <ø> (ø)
...power_generation/unit_models/helm/condenser_ntu.py 82.87% <ø> (ø)
idaes/commands/util/download_bin.py 69.63% <50.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lbianchi-lbl
lbianchi-lbl approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrmundt!

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Jun 9, 2023
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jun 9, 2023
@lbianchi-lbl lbianchi-lbl merged commit d96f560 into IDAES:main Jun 10, 2023
@lbianchi-lbl lbianchi-lbl mentioned this pull request Jun 10, 2023
Closed
lbianchi-lbl pushed a commit that referenced this pull request Jun 30, 2023
@mrmundt @lbianchi-lbl
New version of CI typos tool; fixing previously missed typos (#1204)
1c25fdc 
(cherry picked from commit d96f560)
@ksbeattie ksbeattie added Priority:Normal Normal Priority Issue or PR Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Jul 20, 2023
@mrmundt mrmundt deleted the typos-update branch September 25, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@eslickj eslickj Awaiting requested review from eslickj

@MAZamarripa MAZamarripa Awaiting requested review from MAZamarripa MAZamarripa is a code owner

@aostace01 aostace01 Awaiting requested review from aostace01 aostace01 is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@jsiirola jsiirola Awaiting requested review from jsiirola jsiirola is a code owner

@adowling2 adowling2 Awaiting requested review from adowling2 adowling2 is a code owner

@dangunter dangunter Awaiting requested review from dangunter dangunter is a code owner

@andrewlee94 andrewlee94 Awaiting requested review from andrewlee94

@ksbeattie ksbeattie Awaiting requested review from ksbeattie

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spellcheck CI jobs failing with no change in content being checked

4 participants

@mrmundt @lbianchi-lbl @ksbeattie @idaes-build