Skip to content

Set constraint on IPython version for Python 3.8 support#1179

Merged
lbianchi-lbl merged 1 commit intomainfrom
fix-ipython-3.8
Apr 28, 2023
Merged

Set constraint on IPython version for Python 3.8 support#1179
lbianchi-lbl merged 1 commit intomainfrom
fix-ipython-3.8

Conversation

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Apr 28, 2023

Fixes

Installation failures due to the most recent version of IPython not supporting Python 3.8

image

Changes proposed in this PR:

  • Add constraint to ipython requirement for Python 3.8

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Apr 28, 2023
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review April 28, 2023 16:22
@lbianchi-lbl lbianchi-lbl requested a review from ksbeattie as a code owner April 28, 2023 16:22
@lbianchi-lbl lbianchi-lbl self-assigned this Apr 28, 2023
Copy link
Contributor

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit 558e2af into main Apr 28, 2023
@lbianchi-lbl lbianchi-lbl deleted the fix-ipython-3.8 branch April 28, 2023 16:51
lbianchi-lbl added a commit to lbianchi-lbl/idaes-pse that referenced this pull request May 4, 2023
lbianchi-lbl added a commit that referenced this pull request May 26, 2023
* Remove dependencies without any Ctrl-F-able imports

* Try removing potentially unneeded version constraints

* Use list instead of unsupported set for columns in DataFrame constructor

* Move sympy to optional dependencies

* Remove backport package that has been obsolete since Python 3.3

* Split optional dependencies in categories

* Format with Black

* Add pint to required dependencies

* Try Pyomo implementation of topical optional dependencies

* Split optional dependencies in categories

* Format with Black

* Add pint to required dependencies

* Try Pyomo implementation of topical optional dependencies

* Add pytest.importorskip() directives to DMF test modules

* Move colorama import to function scope

* Track updates to Prescient requirement

* Try handling optional imports at the conftest.py level

* Revert "Add pytest.importorskip() directives to DMF test modules"

This reverts commit 1176954.

* Fix accidental tuplification

* Remove too generic 'optional' target

* Use appropriate version of Pyomo

* Add version constraint for ipython from #1179

* Remove unneeded global variable

* Update dev requirements to track changes in extras_require targets

* Improve pytest plugins to skip tests if registered modules are not found

* Run Black

* Fix typo

* Update site-packages CI job to track changes to extras_require targets

* Resolve Pylint failures

* Modify pytest INI options to support plugins in idaes/conftest.py

* Run Black

* Fix bug causing error running idaes get-extensions in env without pytest

* Trigger CI

* Tweak plugin hooks to support pytest runs outside of source dir

* Add handling for yaml import as pyyaml is now an optional dependency

* Add constraint for urllib3 in dev dependencies

* Handle import of requests for test_model_server.py

* Remove examples extras_require target

* Merge and rename target to omlt

* Reshuffle meta-targets for more differentiation

* Isolate DMF reference in idaes.core.util.convergence.convergence_base

* Format with Black

* Add Pylint directive for import guard

* Revert "Add constraint for urllib3 in dev dependencies"

This reverts commit 00a4e77.

* Remove Python version constraint on coolprop

* Remove catch-all extras_require targets

"Explicit is better than implicit"

* Update Sphinx docs for pip installation

* Replace outdated extras_require targets in CI workflow

* Add how-to guide for installing optional dependencies

* Add ref anchors

---------

Co-authored-by: Ludovico Bianchi <[email protected]>
Co-authored-by: Andrew Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants