Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Update NGCC SOEC example for new costing methods#151

Merged
andrewlee94 merged 11 commits intoIDAES:mainfrom
bpaul4:power-plant-costing
Oct 27, 2022
Merged

Update NGCC SOEC example for new costing methods#151
andrewlee94 merged 11 commits intoIDAES:mainfrom
bpaul4:power-plant-costing

Conversation

@bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Oct 4, 2022 •
edited
Loading

Fixes # .

Proposed changes:

  • Re-runs notebook to remove warnings currently visible in GitHub version of example
  • Updates costing to use new power plant costing methods
  • Note: this will work once Improved Power Plant Costing Methods idaes-pse#978 is merged, and this PR should be merged ASAP afterwards since the new methods will break the existing notebook
  • The head was temporarily changed to 978 to test the example and should be reverted to main once 978 is merged.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 self-assigned this Oct 4, 2022
@bpaul4 bpaul4 mentioned this pull request Oct 4, 2022
Merged
@bpaul4
Copy link
Contributor Author

bpaul4 commented Oct 4, 2022 •
edited
Loading

Until the new power plant costing methods are merged, the expected outcome when using the main idaes-pse branch is that only the NGCC SOEC example fails (due to an ImportError).

@bpaul4 bpaul4 requested a review from MAZamarripa October 5, 2022 13:07
@bpaul4 bpaul4 marked this pull request as ready for review October 5, 2022 14:07
@bpaul4 bpaul4 mentioned this pull request Oct 5, 2022
Closed
@bpaul4 bpaul4 linked an issue Oct 5, 2022 that may be closed by this pull request
CI failures caused by ngcc_soec notebook #150
Closed
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Oct 6, 2022
@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Oct 14, 2022

@bpaul4 I've created a "quick-n-dirty" wiki page on how to set a custom idaes-pse branch for an examples-pse PR: https://github.com/IDAES/examples-pse/wiki/howto-custom-idaes-pse. Feel free to take a look and edit it directly with any corrections or improvements.

lbianchi-lbl
lbianchi-lbl suggested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing against the changes in the PR, this is simply a reminder to restore the idaes-pse pull URL before merging this PR (hopefully pushing that change should automatically dismiss this review; otherwise, feel free to ping me).

@lbianchi-lbl lbianchi-lbl self-requested a review October 14, 2022 16:02
@bpaul4 bpaul4 requested review from AlexNoring and removed request for AlexNoring October 26, 2022 19:31
@ksbeattie ksbeattie mentioned this pull request Oct 27, 2022
Merged
@ksbeattie ksbeattie enabled auto-merge (squash) October 27, 2022 18:47
@ksbeattie ksbeattie disabled auto-merge October 27, 2022 18:48
AlexNoring
AlexNoring approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@AlexNoring AlexNoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewlee94 andrewlee94 merged commit cdbfc16 into IDAES:main Oct 27, 2022
@bpaul4 bpaul4 deleted the power-plant-costing branch September 1, 2023 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MAZamarripa MAZamarripa Awaiting requested review from MAZamarripa

@Daison2102 Daison2102 Awaiting requested review from Daison2102

@eslickj eslickj Awaiting requested review from eslickj

@dallan-keylogic dallan-keylogic Awaiting requested review from dallan-keylogic

2 more reviewers

@AlexNoring AlexNoring AlexNoring approved these changes

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bpaul4 bpaul4

Labels

Priority:Normal Normal Priority Issue or PR

Projects

No open projects
2022 November (previously 2.0.0a3 August) Release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failures caused by ngcc_soec notebook

5 participants

@bpaul4 @lbianchi-lbl @AlexNoring @ksbeattie @andrewlee94