Skip to content

Reorganize dependencies#42

Merged
lbianchi-lbl merged 16 commits intoIDAES:mainfrom
lbianchi-lbl:reorg-deps
Jun 2, 2023
Merged

Reorganize dependencies#42
lbianchi-lbl merged 16 commits intoIDAES:mainfrom
lbianchi-lbl:reorg-deps

Conversation

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented May 9, 2023

Resolves #26

Summary of the changes

  • Name of the Python distribution (i.e. "the thing you pip install") is idaes-examples rather than idaes_examples
  • The following extras_require are available:
    • idaes: Adds idaes-pse, which has been removed from the default requirements
    • omlt: Adds omlt and tensorflow
    • docs: Adds jupyterbook and other packages needed to build documentation
      • Changed from jb to make it more general
    • testing: Adds pytest and other testing dependencies
    • dev: Union of docs and testing
    • packaging: Renamed from pkg for clarity
  • Add requirements-dev.txt (for consistency with idaes-pse)

Outstanding items before being able to merge


Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--42.org.readthedocs.build/en/42/

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label May 9, 2023
@lbianchi-lbl lbianchi-lbl self-assigned this May 9, 2023
@lbianchi-lbl lbianchi-lbl linked an issue May 11, 2023 that may be closed by this pull request
lbianchi-lbl added a commit to lbianchi-lbl/idaes-pse that referenced this pull request May 26, 2023
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review June 2, 2023 18:57
@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) June 2, 2023 19:04
@lbianchi-lbl lbianchi-lbl disabled auto-merge June 2, 2023 19:34
@lbianchi-lbl lbianchi-lbl merged commit 5843259 into IDAES:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Setup fails on ARM64 macOS due to default tensorflow requirement Ensure all required dependencies are specified directly

1 participant