Conversation
lbianchi-lbl
added a commit
to lbianchi-lbl/idaes-pse
that referenced
this pull request
May 26, 2023
This was referenced Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #26
Summary of the changes
pip install") isidaes-examplesrather thanidaes_examplesextras_requireare available:idaes: Addsidaes-pse, which has been removed from the default requirementsomlt: Addsomltandtensorflowdocs: Addsjupyterbookand other packages needed to build documentationjbto make it more generaltesting: Addspytestand other testing dependenciesdev: Union ofdocsandtestingpackaging: Renamed frompkgfor clarityrequirements-dev.txt(for consistency withidaes-pse)Outstanding items before being able to merge
idaes-pseand this repository?setup.pyshouldn't be removed?idaes-pserequirement(s) once Spring cleaning for dependencies, Pt. 2: The Tree-Chopping idaes-pse#1133 has been mergedimportlib.resourcesbackportLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--42.org.readthedocs.build/en/42/