Skip to content

Conversation

@tombrunet
Copy link
Member

@tombrunet tombrunet commented Aug 14, 2025

  • Other (Provide information)

This PR is related to the following issue(s):

I have conducted the following for this PR:

  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolving my comments should make these README changes approved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links to the downloads was incorrectly removed. They should be retained. See old lines 10-18. They allow users to find the packages, such as cucumber, jest, mocha, etc. and related information to 1st set up their environment if not already setup.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, the downloads are listed in the individual README's, but were removed from this top-level boilerplate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Karma has been deprecated, remove those sections

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to where Java can be downloaded & setup, if not already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It added a link, but I'm not sure if that is sufficient

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Karma since it has been deprecated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Karma since it has been deprecated

@tombrunet tombrunet marked this pull request as ready for review August 21, 2025 16:57
@tombrunet tombrunet merged commit 06be2ae into main-4.x Aug 21, 2025
16 checks passed
@tombrunet tombrunet deleted the boilerplate-explanations branch August 21, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R7.0 [ReadMe's]: Review and update packages and boilerplates

3 participants