-
Notifications
You must be signed in to change notification settings - Fork 98
chore(boilerplates): Update the boilerplate READMEs to better explain what's in the boilerplates #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
philljenkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolving my comments should make these README changes approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links to the downloads was incorrectly removed. They should be retained. See old lines 10-18. They allow users to find the packages, such as cucumber, jest, mocha, etc. and related information to 1st set up their environment if not already setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, the downloads are listed in the individual README's, but were removed from this top-level boilerplate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Karma has been deprecated, remove those sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a link to where Java can be downloaded & setup, if not already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It added a link, but I'm not sure if that is sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Karma since it has been deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Karma since it has been deprecated
This PR is related to the following issue(s):
I have conducted the following for this PR:
Assets to aide review attached
Definition of Done