Skip to content

Conversation

@shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Aug 7, 2025

  • Rule bug: element_id_unique, table_aria_descendants

This PR is related to the following issue(s):

Testing reference:

  • Test case 1:
    filter to Rules
  • Before the fix: 250 Violations: "Table structure elements cannot specify an explicit 'role' within table containers"
  • After the fix: none
  • Test case 2: test/v2/checker/accessibility/rules/element_id_unique_ruleunit/Identifiers-notUnique.html
  • Before the fix: Violations "The element has the id "fn1" that is already in use" and "The element has the id "cars1" that is already in use" After the fix: The Violations now are "Needs Review" I have conducted the following for this PR: [x] I validated this code in Chrome and FF [x] I validated this fix in my local env [x] I provided details for testing [ ] This PR has been reviewed and is ready for test [ ] I understand that the title of this PR will be used for the next release notes. Assets to aide review attached [ ] Links to design artifacts [ ] Links to video walkthrough of user experience [ ] Other Definition of Done [ ] Peer review complete [ ] Secondary review complete [ ] Staging deployment verified

@shunguoy shunguoy marked this pull request as ready for review August 8, 2025 14:16
@tombrunet tombrunet merged commit 95bdadf into main-4.x Aug 11, 2025
44 of 48 checks passed
@tombrunet tombrunet changed the title Downgrade the levels of the element_id_unique and table_aria_descendants rules to better line with the requirements fix(engine): Downgrade the levels of the element_id_unique and table_aria_descendants rules to better line with the requirements Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants