fixrule(figure_label_exists, element_scrollable_tabbable): Deprecate element_scrollable_tabbable rule and fix the figure missing label issue V4
#2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(engine): Issues related to `<elements>` made invisible with clip-path
… accessible name requirement when its ancestor is a widget or requires presentational child (#2269) * update the rules and add test cases #dev-syan-v3 * fix formatting of help * Try using npm ci instead of npm test --------- Co-authored-by: Phill Jenkins <[email protected]> Co-authored-by: Tom Brunet <[email protected]>
* chore(archive): Create archive for May 29, 2025 * Hide older archive * Skip end tags for acc name from children * Rebuild
* Try pup update * Update typescript * Change waitForXPath to waitForSelector * params
shunguoy
changed the title
philljenkins
added
engine
philljenkins
changed the title
figure_label_exists, element_scrollable_tabbable): Deprecate fix element_scrollable_tabbable rule and fix the figure missing label issue
Contributor
|
Testing with Artifacts |
tombrunet
approved these changes
Jun 10, 2025
shunguoy
changed the title
figure_label_exists, element_scrollable_tabbable): Deprecate fix element_scrollable_tabbable rule and fix the figure missing label issuefigure_label_exists, element_scrollable_tabbable): Deprecate fix element_scrollable_tabbable rule and fix the figure missing label issue V4
shunguoy
changed the title
figure_label_exists, element_scrollable_tabbable): Deprecate fix element_scrollable_tabbable rule and fix the figure missing label issue V4figure_label_exists, element_scrollable_tabbable): Deprecate element_scrollable_tabbable rule and fix the figure missing label issue V4
philljenkins
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Testing reference:
test case 1 (figure_label_exists rule fix): http://127.0.0.1:5500/test/v2/checker/accessibility/rules/figure_label_exists_ruleunit/figure_with_caption.html
Before the fix: three Recommendations on "The
element does not have an associated label"After the fix: The Recommendations disappear.
test case 2 (element_scroallable_tabbable deprecation)
http://127.0.0.1:5501/accessibility-checker-engine/test/v2/checker/accessibility/rules/element_scrollable_tabbable_ruleunit/act_fail1.html
Before the fix: a Violation on "The scrollable element
After the fix: The Violation disappears.
I have conducted the following for this PR:
Assets to aide review attached
Definition of Done