fixrule(svg_graphics_labelled, img_alt_valid): Ignore SVG & image accessible name requirement when its ancestor is a widget or requires presentational child V4
#2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(engine): Issues related to `<elements>` made invisible with clip-path
sync v4 with v3 dev branch
shunguoy
changed the title
Contributor
|
Testing with accessibility-checker-extension for Chrome will record results in #2224 |
Contributor
|
@shunguoy See blocking comment in #2224 |
philljenkins
changed the title
svg_graphics_labelled, img_alt_valid): Ignore SVG & image accessible name requirement when its ancestor is a widget or requires presentational child V4
tombrunet
approved these changes
May 13, 2025
philljenkins
approved these changes
May 14, 2025
Contributor
philljenkins
left a comment
philljenkins
left a comment
There was a problem hiding this comment.
QA complete, but build failing on extension-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Testing reference:
Before the fix, 2 violations on "The SVG element has no accessible name".
After the fix, only 1 of the violations shows up.
Before the fix, 5 violations on "The image has neither an accessible name nor is marked as decorativ"
After the fix, only 3 of the violations show up.
I have conducted the following for this PR:
Assets to aide review attached
Links to design artifactsLinks to video walkthrough of user experienceOtherDefinition of Done