fixrule(svg_graphics_labelled, img_alt_valid): Ignore SVG & image accessible name requirement when its ancestor is a widget or requires presentational child
#2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunguoy
changed the title
Contributor
|
@shunguoy See blocking approval #2224 (comment) |
philljenkins
changed the title
svg_graphics_labelled, img_alt_valid): Ignore SVG & image accessible name requirement when its ancestor is a widget or requires presentational child
tombrunet
previously approved these changes
May 13, 2025
philljenkins
previously approved these changes
May 14, 2025
Contributor
philljenkins
left a comment
philljenkins
left a comment
There was a problem hiding this comment.
QA complete, but build failing on extension-test
tombrunet
added a commit
that referenced
this pull request
Jun 9, 2025
* update baselines #dev-2219 * update baselines #dev-2219 * fixrule(`svg_graphics_labelled`, `img_alt_valid`): Ignore SVG & image accessible name requirement when its ancestor is a widget or requires presentational child (#2269) * update the rules and add test cases #dev-syan-v3 * fix formatting of help * Try using npm ci instead of npm test --------- Co-authored-by: Phill Jenkins <[email protected]> Co-authored-by: Tom Brunet <[email protected]> * chore(archive): Create archive for May 29, 2025 (#2297) * chore(archive): Create archive for May 29, 2025 * Hide older archive * Skip end tags for acc name from children * Rebuild * Try pup update * Update typescript * Change waitForXPath to waitForSelector * params --------- Co-authored-by: Shunguo <[email protected]> Co-authored-by: Phill Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Testing reference:
Before the fix, 2 violations on "The SVG element has no accessible name".
After the fix, only 1 of the violations shows up.
Before the fix, 5 violations on "The image has neither an accessible name nor is marked as decorativ"
After the fix, only 3 of the violations show up.
I have conducted the following for this PR:
Assets to aide review attached
Links to design artifactsLinks to video walkthrough of user experienceOtherDefinition of Done