Skip to content

feature(node): Add configuration "puppeteerArgs" to allow args to be set when running batch scans (4.x) #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philljenkins merged 5 commits into from
Apr 22, 2025
Merged

feature(node): Add configuration "puppeteerArgs" to allow args to be set when running batch scans (4.x) #2252

philljenkins merged 5 commits into from
Apr 22, 2025

Conversation

@tombrunet
Copy link
Member

@tombrunet tombrunet commented Apr 17, 2025 •
edited by philljenkins
Loading

  • Other (Provide information)
    This PR adds a configuration option that allows Puppeteer args to be passed to the instance of Puppeteer created when using the batch scanning operation.

The configuration might look like this for .yml:

puppeteerArgs:
  - --no-sandbox
  - --disable-setuid-sandbox

Or this attribute added to a .json config:

puppeteerArgs: [ "--no-sandbox", "--disable-setuid-sandbox" ]

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • NA Links to design artifacts
  • NA Links to video walkthrough of user experience
  • NA Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

shunguoy
shunguoy previously approved these changes Apr 17, 2025
View reviewed changes
@tombrunet tombrunet requested a review from philljenkins April 21, 2025 14:08
@philljenkins philljenkins mentioned this pull request Apr 22, 2025
Closed
@philljenkins
Copy link
Contributor

philljenkins commented Apr 22, 2025

When testing in Chrome vs Firefox on Altoro Mutual demo site, results are the same

@philljenkins philljenkins mentioned this pull request Apr 22, 2025
Merged
10 tasks
@philljenkins
Copy link
Contributor

philljenkins commented Apr 22, 2025

Same results in
v3.x #2251
v4.x #2252

@philljenkins philljenkins merged commit c4504e3 into main-4.x Apr 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shunguoy shunguoy shunguoy approved these changes

@philljenkins philljenkins Awaiting requested review from philljenkins

Assignees

@philljenkins philljenkins

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Accessibility Checker fails when running in Ubuntu latest version 24.4

4 participants

@tombrunet @philljenkins @shunguoy