Skip to content

fixrule(input_label_exists, aria_widget_labelled, aria_accessiblename_exists): Update accessible name requirement for certain roles #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tombrunet merged 4 commits into from
Apr 24, 2025
Merged

fixrule(input_label_exists, aria_widget_labelled, aria_accessiblename_exists): Update accessible name requirement for certain roles #2243

tombrunet merged 4 commits into from
Apr 24, 2025

Conversation

@shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 9, 2025 •
edited by philljenkins
Loading

  • Rule bug: input_label_exists, aria_widget_labelled, aria_accessiblename_exists

This PR is related to the following issue(s):

Testing reference:

  • test case: test/v2/checker/accessibility/rules/aria_accessiblename_exists_ruleunit/elements-no-label.html
  • Switch to "Rules"
  • Before the fixes: there were 8 violations: "Interactive component must have a programmatically associated name", with one for "radiogroup" and one for "alertdialog".
    and 5 recommendations: "Elements with certain roles should have accessible names", with one for "form" and one for "table".
  • After the fixes: 6 violations, no violation for "radiogroup" or "alertdialog".
    and 3 recommendations, no recommendations for "form" or "table".

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy marked this pull request as ready for review April 15, 2025 14:05
@tombrunet tombrunet merged commit a6d2e3c into master Apr 24, 2025
17 checks passed
tombrunet added a commit that referenced this pull request Apr 24, 2025
@tombrunet @philljenkins @shunguoy
chore(archive): Create archive for April 24, 2025 (4.x) (#2260)
9d0cf68 
* fixrule(`input_label_exists`, `aria_widget_labelled`, `aria_accessiblename_exists`): Update accessible name requirement for certain roles (#2243)

* update aria definition and engine logic #dev-1920

* update test cases #dev-1920

---------

Co-authored-by: Phill Jenkins <[email protected]>

* Create April 24 archive

---------

Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Shunguo Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tombrunet tombrunet tombrunet approved these changes

@philljenkins philljenkins Awaiting requested review from philljenkins

Assignees

@philljenkins philljenkins

@tombrunet tombrunet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix issues related to the tabbable widget with role 'none' Handle case where nameRequired is true, but not a widget

4 participants

@shunguoy @tombrunet @philljenkins