Skip to content

fix(engine): Update the landmark label uniqueness rules and deprecate meta_redirect_optional rule #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philljenkins merged 11 commits into from
Apr 15, 2025
Merged

fix(engine): Update the landmark label uniqueness rules and deprecate meta_redirect_optional rule #2239

philljenkins merged 11 commits into from
Apr 15, 2025

Conversation

@shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 1, 2025 •
edited by philljenkins
Loading

  • Rule bug: ** 11 landmark rules**

This PR is related to the following issue(s):

Testing reference:

  • test cases: "test/v2/checker/accessibility/rules/aria_search_label_unique_ruleunit/search_hidden.html"
  • before the fix: multiple violations with "Multiple elements with "search" landmarks within the same parent region are not distinguished from one another because they have the same "my section" label".
  • after the fix: the error should disappear.
  • Other similar test cases are in est/v2/checker/accessibility/rules/aria_<LandmarkName_label_unique_ruleunit/_hidden.html

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review & QA testing complete
  • Staging deployment verified

@shunguoy shunguoy changed the title fix(engine`): update the landmark rules with labels and deprecate meta_redirect_optional rule fix(engine): update the landmark rules with labels and deprecate meta_redirect_optional rule Apr 1, 2025
@shunguoy shunguoy changed the title fix(engine): update the landmark rules with labels and deprecate meta_redirect_optional rule fix(engine): update the landmark label uniqueness rules and deprecate meta_redirect_optional rule Apr 3, 2025
@shunguoy shunguoy marked this pull request as ready for review April 10, 2025 20:28
@philljenkins
Copy link
Contributor

philljenkins commented Apr 11, 2025

Testing not complete, will be tagged with 'Ready for QA' when testing is complete

@philljenkins philljenkins changed the title fix(engine): update the landmark label uniqueness rules and deprecate meta_redirect_optional rule fix(engine): Update the landmark label uniqueness rules and deprecate meta_redirect_optional rule Apr 11, 2025
@philljenkins
Copy link
Contributor

philljenkins commented Apr 15, 2025

Testing complete, will merge in next standup or retro

philljenkins
philljenkins approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing complete, will merge in next standup or retro

@philljenkins philljenkins merged commit 006914b into master Apr 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tombrunet tombrunet tombrunet approved these changes

+1 more reviewer

@philljenkins philljenkins philljenkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@philljenkins philljenkins

@tombrunet tombrunet

Labels

Ready for QA

Projects

None yet

Milestone

No milestone

4 participants

@shunguoy @philljenkins @tombrunet