Repository navigation
fix(test): capture logs without replacing the global Logger - #3737
Merged
Merged
Conversation
Signed-off-by: Burak Keskin <[email protected]>
puellanivis
reviewed
Sep 2, 2026
puellanivis
left a comment
puellanivis
left a comment
Collaborator
There was a problem hiding this comment.
:not-bad: A pretty simple and measured solution.
Comment on lines
+26
to
+35
| std, ok := Logger.(*log.Logger) | ||
| if !ok { | ||
| orig := Logger | ||
| Logger = log.New(w, "", 0) | ||
| t.Cleanup(func() { Logger = orig }) | ||
| return | ||
| } | ||
| prev := std.Writer() | ||
| std.SetOutput(w) | ||
| t.Cleanup(func() { std.SetOutput(prev) }) |
Collaborator
There was a problem hiding this comment.
🤔 Maybe a type switch? Then we don’t need the early return, as each type would be a separate case?
Signed-off-by: Dominic Evans <[email protected]>
dnwe
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry this showed up as a
go test -racefailure after a close.TestPartitionConsumerComputeBackoffwas replacing the packageLoggerwhileTestConsumerExpiryTickerstill had asafeAsyncClosegoroutine reading it throughDebugLogger.The stuck-warning subtest now uses
(*log.Logger).SetOutput, which is documented as safe for concurrent use, so leftover close logs no longer race with the capture.TestClientBackgroundMetadataUpdaterhad the same assignment, so I pointed that at the same helper.Fixes #3736.