Skip to content

ci(lint): unblock Go 1.26 lint and handle gosec noise#3454

Merged
dnwe merged 2 commits intoIBM:mainfrom
DCjanus:fix/ci-golangci-lint-go126
Feb 27, 2026
Merged

ci(lint): unblock Go 1.26 lint and handle gosec noise#3454
dnwe merged 2 commits intoIBM:mainfrom
DCjanus:fix/ci-golangci-lint-go126

Conversation

@DCjanus
Copy link
Copy Markdown
Contributor

@DCjanus DCjanus commented Feb 26, 2026

Summary

  • bump GOLANGCI_LINT_VERSION from v2.8.0 to v2.10.1
  • add targeted #nosec suppressions for newly surfaced gosec findings:
    • G117 for required exported Password API/config fields
    • G704 for internal/toxiproxy HTTP calls in controlled test infrastructure

Why

  • GitHub Actions stable now resolves to Go 1.26
  • with golangci-lint v2.8.0, lint panics (application built with go1.25)
  • after upgrading linter, CI surfaces existing false-positive-prone gosec findings and fails

Testing

  • go test ./...

Discussion

  • For long-term maintenance, should we keep targeted suppressions, or prefer a repo-level policy for G117 / G704?

@DCjanus DCjanus force-pushed the fix/ci-golangci-lint-go126 branch from 41fba3d to 4ae2f25 Compare February 26, 2026 17:58
Copy link
Copy Markdown
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very helpful PR

@dnwe dnwe merged commit e46c213 into IBM:main Feb 27, 2026
17 checks passed
@dnwe dnwe added the chore label Feb 27, 2026
@DCjanus DCjanus deleted the fix/ci-golangci-lint-go126 branch February 27, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants