test: expand Java interop tests to cover all compression codecs#3423
Merged
test: expand Java interop tests to cover all compression codecs#3423
Conversation
Signed-off-by: Dominic Evans <[email protected]>
Conditionally set producer/consumer arguments Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
puellanivis
reviewed
Jan 11, 2026
| scanner := bufio.NewScanner(stderr) | ||
| for scanner.Scan() { | ||
| stderrOutput.WriteString(scanner.Text() + "\n") | ||
| s := bufio.NewScanner(stderr) |
Collaborator
There was a problem hiding this comment.
Shouldn’t we have a s.Err() test as a sanity check? (If it ever happens, and we’re not reporting it, it could lead to a difficult debug.)
functional_java_interop_test.go
Outdated
Comment on lines
+267
to
+268
| "--offset", fmt.Sprintf("%d", startOffset), | ||
| "--max-messages", fmt.Sprintf("%d", count), |
Collaborator
There was a problem hiding this comment.
I’m not sure how much of a difference this would actually make though:
Suggested change
| "--offset", fmt.Sprintf("%d", startOffset), | |
| "--max-messages", fmt.Sprintf("%d", count), | |
| "--offset", fmt.Sprint(startOffset), | |
| "--max-messages", fmt.Sprint(count), |
Signed-off-by: Dominic Evans <[email protected]>
| waitErr := cmd.Wait() | ||
| require.NoError(t, waitErr, "Java producer failed") | ||
| } | ||
| require.NoError(t, err) |
Member
There was a problem hiding this comment.
if waitErr is not nil the test failure will hide the previous err - what about
- require.NoError(t, waitErr, "Java producer failed")
+ if waitErr != nil {
+ err = fmt.Errorf("failed to write message: %w; Java producer failed: %w", err, waitErr)
+ }
+ require.NoError(t, err)
}
- require.NoError(t, err)
Collaborator
There was a problem hiding this comment.
I mean, if we already know we’re going to fail the NoError just put a t.Fatal in directly?
PS: I would recommend just using assert.NoError(t, waittErr) instead?
Signed-off-by: Dominic Evans <[email protected]>
edoardocomar
approved these changes
Jan 11, 2026
Member
|
LGTM thanks @dnwe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.