chore: migrate from eapache/go-xerial-snappy to klauspost/compress/sn…#3421
Merged
chore: migrate from eapache/go-xerial-snappy to klauspost/compress/sn…#3421
Conversation
edoardocomar
force-pushed
the
ec/snappy
branch
from
3a2fc5c to
5586ffd
Compare
…appy/xerial Replace abandoned eapache/go-xerial-snappy with klauspost/compress/snappy/xerial which is already used for other compression codecs (gzip, zstd). - Update Encode() API call to match new signature (Encode(dst, src []byte)) - Update test expectations in record_test.go for new xerial format - Remove eapache/go-xerial-snappy dependency from go.mod All unit and functional tests passing. Signed-off-by: Edoardo Comar <[email protected]>
edoardocomar
force-pushed
the
ec/snappy
branch
2 times, most recently
from
23a26dc to
4d45d42
Compare
…rip compatibility Add two functional tests to verify snappy compression compatibility: - TestJavaProducerSnappyRoundTrip: Java console producer -> Sarama consumer - TestSaramaProducerToJavaConsumerSnappy: Sarama producer -> Java console consumer Signed-off-by: Edoardo Comar <[email protected]>
edoardocomar
force-pushed
the
ec/snappy
branch
from
4d45d42 to
0fccd1d
Compare
Signed-off-by: Dominic Evans <[email protected]>
dnwe
approved these changes
Jan 11, 2026
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks, I added a small extra commit to re-use some of the existing helpers but otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…appy/xerial
Replace eapache/go-xerial-snappy with klauspost/compress/snappy/xerial which is already used for other compression codecs (gzip, zstd).