fix(admin): retry on network errors by resetting controller connection#3406
Closed
fix(admin): retry on network errors by resetting controller connection#3406
Conversation
Signed-off-by: DCjanus <[email protected]>
Signed-off-by: DCjanus <[email protected]>
Contributor
Author
|
After further consideration, I realized that my fix was incorrect, and I need to think more about a more appropriate implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ErrNotController/EOFas retriable (definition atadmin.go#L214-L225), so network errors bubble out without healing the connection.What’s changed
net.Error,io.ErrUnexpectedEOF,EPIPE) as retriable in admin/controller paths.retryOnError, close the cached controller connection before the next attempt; the subsequent call toController()in each admin operation (e.g.CreateTopicatadmin.go#L265-L288) reopens a fresh TCP socket automatically.Why it’s safe
admin.go#L230-L242). Healthy calls are untouched.ErrNotControllerpath, which already triggersRefreshController()—same behavior as today, just without reusing a broken socket.