fix: correct ApiVersionsResponse handling of ErrUnsupportedVersion#3337
Merged
fix: correct ApiVersionsResponse handling of ErrUnsupportedVersion#3337
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
dnwe
force-pushed
the
dnwe/apiversions
branch
2 times, most recently
from
2df8318 to
2b88f9f
Compare
Improve the api_versions_response_test.go to be more representative of the different good and bad responses it might receive. Subsequently fix the ApiVersionsResponse decoding so that it correctly downgrades the decoder from flexible to non-flexible after reading the ErrorCode of UnsupportedVersion Signed-off-by: Dominic Evans <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the api_versions_response_test.go to be more representative of the different good and bad responses it might receive.
Subsequently fix the ApiVersionsResponse decoding so that it correctly downgrades the decoder from flexible to non-flexible after reading the ErrorCode of UnsupportedVersion