fix: improve KIP-511 behaviour on older Kafka clusters#3328
Merged
Conversation
dnwe
force-pushed
the
dnwe/improve-apiversions
branch
from
f78a4de to
80b298b
Compare
Rather than failing with "not enough bytes to read" when parsing the ApiVersionsResponse (and always sending a V0 as fallback), instead follow the KIP and expect a V0 ApiVersionsResponse to have been sent back with the supported ApiVersions apikey version included in it. Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
dnwe/improve-apiversions
branch
from
80b298b to
de2c08a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than failing with "not enough bytes to read" when parsing the ApiVersionsResponse (and always sending a V0 as fallback), instead follow the KIP and expect a V0 ApiVersionsResponse to have been sent back with the supported ApiVersions apikey version included in it.