fix(fvt): simplify retry using testify's EventuallyWithT#3324
Merged
Conversation
Experiment with using testify to make this assertion block cleaner and more reliable. Also allow up to 10 seconds wait time. Signed-off-by: Dominic Evans <[email protected]>
hindessm
approved these changes
Oct 2, 2025
puellanivis
reviewed
Oct 6, 2025
Comment on lines
+74
to
+76
| require.NoError(t, err) | ||
| require.NotEmpty(t, quotas, "Expected not empty quotas for default user") | ||
| require.Len(t, quotas, 1, "Expected one quota entry for default user") |
Collaborator
There was a problem hiding this comment.
😬 if these are beign called from within a goroutine, that technically violates a precondition of testing.T.FailNow:
FailNow must be called from the goroutine running the test or benchmark function, not from other goroutines created during the test. Calling FailNow does not stop those other goroutines.
https://pkg.go.dev/[email protected]#T.FailNow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment with using testify to make this assertion block cleaner and more reliable. Also allow up to 10 seconds wait time.