chore(fvt): refactor docker-compose and support KRaft#3323
Merged
Conversation
- make use of docker compose 'fragments' (yaml anchors) to reduce a lot of duplication in the docker-compose - remove the pinned commit we were using to test Kafka 4.0 with ZooKeeper support and start testing against the release with KRaft enabled - use the entrypoint.sh to remove the inappropriate broker properties if in zookeeper mode or kraft mode respectively - don't start the zookeeper containers unless `--profile zookeeper` is passed, this saves on the resource at the cost of not necessarily being obvious to a casual user. It's a shame we can't selectively start them based on KAFKA_VERSION Signed-off-by: Dominic Evans <[email protected]>
hindessm
approved these changes
Oct 1, 2025
When running Kafka in KRaft mode there seems to be additional latency between adding a client quota and it being available on a DescribeClientQuotas call. Add a few short retries in the test to account for that lag. Signed-off-by: Dominic Evans <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--profile zookeeperis passed, this saves on the resource at the cost of not necessarily being obvious to a casual user. It's a shame we can't selectively start them based on KAFKA_VERSION