fix: non-flexible ElectLeadersRequest V0/V1 encode/decode#3312
Merged
fix: non-flexible ElectLeadersRequest V0/V1 encode/decode#3312
Conversation
And clean up the misleading layout/comment of the []bytes in the test Signed-off-by: beanz <[email protected]>
Collaborator
|
Aside: we probably should have a functional test for elect leaders as I feel like this has likely never properly worked? |
This was referenced Mar 19, 2026
dnwe
pushed a commit
that referenced
this pull request
Mar 20, 2026
## Why `ElectLeaders` request/response version 1 must use the non-flexible wire format. That path was fixed once in #3312, but a later refactor left the `ElectLeaders` header version selection inconsistent with the protocol version again. As a result, a client configured for `V2_3_0_0` can fail to decode `ElectLeaders` V1 responses from newer brokers with: `kafka: insufficient data to decode packet, more bytes expected` ## What - add a functional test that covers low-version client compatibility against newer brokers for the `ElectLeaders` V1 non-flexible path - select `ElectLeaders` request/response header versions from the actual protocol version instead of treating V1 as flexible ## Testing This PR contains two commits. The first commit only adds a functional test and is expected to fail. The second commit only contains the protocol fix and is expected to make CI pass. Before opening this PR, I created a draft PR in my fork to run CI and verify that the test was actually effective. - failing job: [FVT (PR) / Kafka 2.6.3](https://github.com/DCjanus/sarama/actions/runs/23286394025/job/67710812112) - passing job: [FVT (PR) / Kafka 2.6.3](https://github.com/DCjanus/sarama/actions/runs/23286993578/job/67712775310) --------- Signed-off-by: DCjanus <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And clean up the misleading layout/comment of the []bytes in the test:
Test layout for V2
[]bytewas:but, while the bytes were correct the comments were misleading as the encoding is really: