Conversation
V5 adds a new error code, OFFSET_NOT_AVAILABLE, but is otherwise identical to V4 Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
dnwe/v5-listoffsets
branch
from
df40ff0 to
68e2da0
Compare
hindessm
approved these changes
Sep 25, 2025
puellanivis
reviewed
Sep 26, 2025
| blocks map[string]map[int32]*offsetRequestBlock | ||
| } | ||
|
|
||
| func NewOffsetRequest(version KafkaVersion) *OffsetRequest { |
Collaborator
There was a problem hiding this comment.
Did we want to export this? (I suspect yes, because we export a lot of request constructors).
Collaborator
Author
There was a problem hiding this comment.
Yeah at the moment we export all the protocol, that may change when we move to a v2 api, but for now we keep them the same
Collaborator
There was a problem hiding this comment.
Well, I think mentioned elsewhere, for a v2 we probably want to split up the protocol from the API. That’s what I also did with sftp v2.
Building a transparent shim of the protocol, and then the complex API hiding implementation details really simplified a lot of the exposed API, while keeping the protocol open and standardized as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V5 adds a new error code, OFFSET_NOT_AVAILABLE, but is otherwise identical to V4