fix: extend TestAllocateBodyProtocolVersions for more testing#3307
Merged
Conversation
Collaborator
dnwe
commented
Sep 25, 2025
dnwe
commented
- refactor the existing tests for 2.0.0 and 2.1.0 to only test the api keys that changed in version
- similarly add a 2.2.0 variant so we can start to tickoff completion
- add a "max version" test that attempts to ensure we've got matching requiredVersion etc. in the request and response for all the versions we've currently implemented
hindessm
approved these changes
Sep 25, 2025
- refactor the existing tests for 2.0.0 and 2.1.0 to only test the api keys that changed in version - similarly add a 2.2.0 variant so we can start to tickoff completion - add a "max version" test that attempts to ensure we've got matching requiredVersion etc. in the request and response for all the versions we've currently implemented Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
dnwe/request-test
branch
from
1cff5cd to
54e5f60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.