fix: metadata_response valid version range#3304
Merged
Conversation
hindessm
changed the title
Missed from 76ca69a which added more versions Signed-off-by: beanz <[email protected]>
hindessm
force-pushed
the
fix-metadata-response-valid-versions
branch
from
803f034 to
ba67340
Compare
dnwe
approved these changes
Sep 25, 2025
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks! We actually have a unittest that should have caught this, but we only run it up to Kafka 2.1.0.0 protocol versions, I'll take a look to see how much we can extend that now, at least for a selection of apikeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed from 76ca69a which added more versions