Merged
Conversation
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
hindessm
approved these changes
Sep 18, 2025
puellanivis
reviewed
Sep 19, 2025
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
I know it’s already merged, but spotted a few further polishings.
| for group, typ := range response.Groups { | ||
| groups[group] = typ | ||
| } | ||
| maps.Copy(groups, response.Groups) |
Collaborator
There was a problem hiding this comment.
Since we’re also making the map on line 1034, we can replace this with groups := maps.Clone(response.Groups)
| for k, v := range currentPartitionConsumer { | ||
| preBalancePartitionConsumers[k] = v | ||
| } | ||
| maps.Copy(preBalancePartitionConsumers, currentPartitionConsumer) |
Collaborator
There was a problem hiding this comment.
This is also a good candidate for maps.Clone
| for k, v := range preBalancePartitionConsumers { | ||
| currentPartitionConsumer[k] = v | ||
| } | ||
| maps.Copy(currentPartitionConsumer, preBalancePartitionConsumers) |
| } | ||
| } | ||
| return false | ||
| return slices.Contains(assignments, topic) |
Collaborator
There was a problem hiding this comment.
We might want to replace the actual function calls to this unexported function to slices.Contains itself?
Comment on lines
+2205
to
2206
| found := slices.Contains(consumers[memberID].Topics, assignedTopic) | ||
| if !found { |
Collaborator
There was a problem hiding this comment.
No need to go through a temporary local variable anymore, we could just do the slices.Contains directly in the if condition.
| for k, v := range handlerMap { | ||
| fnMap[k] = v | ||
| } | ||
| maps.Copy(fnMap, handlerMap) |
| for k, v := range handlerMap { | ||
| fnMap[k] = v | ||
| } | ||
| maps.Copy(fnMap, handlerMap) |
Comment on lines
+106
to
+107
| arrHdrs := strings.SplitSeq(*headers, ",") | ||
| for h := range arrHdrs { |
Collaborator
There was a problem hiding this comment.
No need to pass this through a temporary local variable.
Comment on lines
+1673
to
1675
| resp := fmt.Appendf(nil, "n,,\x01auth=Bearer %s%s\x01\x01", token.Token, ext) | ||
|
|
||
| return resp, nil |
Collaborator
There was a problem hiding this comment.
This doesn’t seem to be necessary to pass through a temporary local variable, but the composed return might look more odd.
hindessm
added a commit
to hindessm/sarama
that referenced
this pull request
Sep 22, 2025
These are the uncontentious changes mentioned after the merge of the earlier modernize PR. See: IBM#3297 (review) Co-authored-by: Cassondra Foesch <[email protected]> Signed-off-by: beanz <[email protected]>
hindessm
added a commit
to hindessm/sarama
that referenced
this pull request
Sep 22, 2025
These are the uncontentious changes mentioned after the merge of the earlier modernize PR. See: IBM#3297 (review) Co-authored-by: Cassondra Foesch <[email protected]> Signed-off-by: beanz <[email protected]>
hindessm
added a commit
that referenced
this pull request
Sep 23, 2025
These are the uncontentious changes mentioned after the merge of the earlier modernize PR. See: #3297 (review) Co-authored-by: Cassondra Foesch <[email protected]> Signed-off-by: beanz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply a selection of the gopls modernize fixes category-by-category: