feat: support more describe log dirs versions (V2-V4)#3293
Merged
Conversation
dnwe
changed the title
Collaborator
|
@hindessm thanks! I added a simple FV to PR just to exercise it across the kafka versions within GHA |
puellanivis
reviewed
Sep 16, 2025
describe_log_dirs_request.go
Outdated
| if err := pe.putCompactInt32Array(d.PartitionIDs); err != nil { | ||
| return err | ||
| } | ||
| if isFlexible { |
Collaborator
There was a problem hiding this comment.
This test is already known to be true, because we’re in an if isFlexible conditional.
hindessm
force-pushed
the
more-log-dirs-support
branch
from
8a4d2d1 to
7104470
Compare
Signed-off-by: beanz <[email protected]>
Exercise the new protocol in the FV Signed-off-by: Dominic Evans <[email protected]>
hindessm
force-pushed
the
more-log-dirs-support
branch
from
7104470 to
e93be72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2 is the first flexible version.
Version 3 adds the top-level ErrorCode field
Version 4 adds the TotalBytes and UsableBytes fields