chore: replace unnecessary go-multierror dependency#3243
Conversation
puellanivis
reviewed
Aug 8, 2025
puellanivis
reviewed
Aug 9, 2025
dnwe
changed the title
puellanivis
reviewed
Aug 14, 2025
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
Code looks fine, only some godoc lint.
No need to wait for a reapproval from me if this is the only change taken after this.
errors.go
Outdated
Comment on lines
+92
to
+93
| // Deprecated: MultiErrorFormat specifies the formatter applied to format multierrors. | ||
| // Please use errors.Join() instead |
Collaborator
There was a problem hiding this comment.
Godoc should still start with the exported symbol name. The deprecation should follow the first paragraph as a separate paragraph.
Suggested change
| // Deprecated: MultiErrorFormat specifies the formatter applied to format multierrors. | |
| // Please use errors.Join() instead | |
| // MultiErrorFormat specifies the formatter applied to format multierrors. | |
| // | |
| // Deprecated: Please use [errors.Join] instead. |
It could potentially also still include the information about how it’s copying hashicorp’s multierror despite us no longer including the import. Since its style still(?) copies their format.
Contributor
Author
There was a problem hiding this comment.
I've updated the deprecation notice, running go fmt errors.go it does not produce any code changes.
added 7 commits
August 16, 2025 13:52
Signed-off-by: bestbug456 <[email protected]>
Signed-off-by: bestbug456 <[email protected]>
Signed-off-by: bestbug456 <[email protected]>
Signed-off-by: bestbug456 <[email protected]>
Signed-off-by: bestbug456 <[email protected]>
Signed-off-by: bestbug456 <[email protected]>
Signed-off-by: bestbug456 <[email protected]>
dnwe
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This proposal of changes remove the hashicorp dependencies, after scratching my head for a while I was not able to seen a good reason for keeping this dependencies and I hope that this commit was able to achieve it without losing any functionalities, at least from test execution everything looks like as before. The reason why I'm proposing this change is for two reason:
Thanks for your time in reading this pull request!