feat(protocol): support CreateTopicRequest V4#3238
Merged
Conversation
Add support for using CreateTopicRequest V4 against Kafka 2.4 and newer clusters. Protocol-wise this is identical to the existing V3, but the version indicates that the server should accept `-1` as the partition and replicate-factor values to indicate "use the server side defaults" (KIP-464). Contributes-to: #3233 Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
dnwe/create-topics-request-v4
branch
from
6ec5bfb to
51a5b57
Compare
prestona
approved these changes
Aug 6, 2025
puellanivis
reviewed
Aug 8, 2025
| version KafkaVersion, | ||
| topicDetails map[string]*TopicDetail, | ||
| timeout time.Duration, | ||
| validateOnly bool, |
Collaborator
There was a problem hiding this comment.
😬 this is a breaking change.
Fortunately, it seems no one is actually using this exported function though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for using CreateTopicRequest V4 against Kafka 2.4 and newer clusters. Protocol-wise this is identical to the existing V3, but the version indicates that the server should accept
-1as the partition and replicate-factor values to indicate "use the server side defaults" (KIP-464).Contributes-to: #3233