feat: always send ApiVersionsRequest and fallback to v0#3234
Merged
Conversation
We previously pinned to only sending if Version was set to v2.4.0.0, but we should always send the request regardless, but fallback to sending a v0 request (without client info) if the v3 request does not succeed In functional tests we always use MaxVersion in config an ApiVersionsRequest enabled to negotiate versions. In unittests we disable ApiVersionsRequest by default and pin Version. A number of these tests use step-by-step ordered protocol expectations and it isn't convenient to update them all to also include an ApiVersionsRequest roundtrip unnecessarily, so we disable it in plain unittests by default, keeping it as opt-in. Signed-off-by: Dominic Evans <[email protected]> Co-authored-by: Giorgio Pellero <[email protected]>
trapped
reviewed
Aug 4, 2025
| // Don't return here - continue without API version discovery | ||
| } else { | ||
| // send a v0 request in case remote cluster is < 2.4.0.0 | ||
| apiVersionsResponse, _ = b.sendAndReceiveApiVersions(0) |
Contributor
There was a problem hiding this comment.
Nice 👌 I missed this detail in my original PR.
prestona
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously pinned to only sending if Version was set to v2.4.0.0, but we should always send the request regardless, but fallback to sending a v0 request (without client info) if the v3 request does not succeed
In functional tests we always use MaxVersion in config an ApiVersionsRequest enabled to negotiate versions.
In unittests we disable ApiVersionsRequest by default and pin Version. A number of these tests use step-by-step ordered protocol expectations and it isn't convenient to update them all to also include an ApiVersionsRequest roundtrip unnecessarily, so we disable it in plain unittests by default, keeping it as opt-in.