Conversation
dnwe
force-pushed
the
sarama-golangci-lint
branch
from
a163d74 to
d9b2470
Compare
The golangci-lint action is refusing to use the older version of golangci-lint now, so bump to latest v2 and run `golangci-lint migrate` to convert the config file to the latest format Signed-off-by: Dominic Evans <[email protected]>
hindessm
approved these changes
May 19, 2025
Collaborator
hindessm
left a comment
hindessm
left a comment
There was a problem hiding this comment.
LGTM (I appreciate that you took the time to put the comments back after migration!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golangci-lint action is refusing to use the older version of golangci-lint now, so bump to latest v2 and run
golangci-lint migrateto convert the config file to the latest format