fix: send null instead of empty string when describing default client quotas#3128
Merged
fix: send null instead of empty string when describing default client quotas#3128
Conversation
Signed-off-by: Peter Dannemann <[email protected]>
petedannemann
changed the title
Signed-off-by: Peter Dannemann <[email protected]>
dnwe
approved these changes
Mar 19, 2025
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks! This does indeed look like a bug in the original implementation, thanks for the fix
Signed-off-by: Peter Dannemann <[email protected]>
petedannemann
force-pushed
the
fix/describe-default-quota
branch
from
39f5433 to
fa7d527
Compare
Contributor
Author
|
Thanks for the review, my mistake for missing the unit test there, I think I may have only ran the functional tests on my machine |
Contributor
Author
|
@dnwe curious if you have a date in mind for the next Sarama release? I was hoping to leverage this feature here Mongey/terraform-provider-kafka#527 EDIT: nevermind, that maintainer was fine with using an untagged version of sarama |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DescribeClientQuota currently fails with the following error message logged by the Kafka broker when trying to describe default client quotas:
This is because we are currently sending an empty string (
"") instead of a null as the match stringThe Java client simply ignores the match string here to avoid this issue, so I propose we do the same https://github.com/apache/kafka/blob/3ed590288fd773902f7791959e8f081ff937c144/clients/src/main/java/org/apache/kafka/common/requests/DescribeClientQuotasRequest.java#L54-L55