Conversation
…ead of 0 Signed-off-by: Matteo Agius <[email protected]>
magiusdarrigo
force-pushed
the
magius/patch-SyncProducer-SendMessage-mock
branch
from
5924a08 to
7f57c8e
Compare
Contributor
Author
|
Hi @dnwe can you take a look when get the time, thanks |
puellanivis
reviewed
Mar 11, 2025
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
👍 looks good from me, and makes a lot of sense. (That is, this looks like a straight bug fix.)
Contributor
Author
|
Any timeline on when this fix can get merged @puellanivis |
Collaborator
|
I am not actually one of the maintainers. My (Contributor) status comes from having a PR merged. |
dnwe
approved these changes
Mar 12, 2025
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks for the PR! This does just look like a mistake in the original mock that had gone undiscovered until now
dnwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.