feat(producer): add sync pool for channel reuse#3109
Merged
Conversation
puellanivis
reviewed
Feb 27, 2025
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
That the only thing I can find to comment about is a variable name says good things for the PR. 😉
added 3 commits
February 27, 2025 14:09
Signed-off-by: k.torgaev <[email protected]>
Signed-off-by: k.torgaev <[email protected]>
Signed-off-by: k.torgaev <[email protected]>
kasimtj
force-pushed
the
feature/sync-pool-for-expectation-channels-reuse
branch
from
fa2d663 to
6d63ab0
Compare
puellanivis
reviewed
Feb 28, 2025
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
I can see nothing worth commenting about.
Contributor
Author
should i tag maintainers for a review or just wait for someone? |
dnwe
changed the title
dnwe
approved these changes
Mar 2, 2025
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks for the PR and issue/benchmark comparison. Changed look good to me, approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this issue #3107