Merged
Conversation
Similar to other clients, set the MaxTimestamp computed from the records in the batch. Signed-off-by: Tyler Rockwood <[email protected]>
|
This issue is blocking us from using sarama with redpanda, which currently depends on MaxTimestamp being set, otherwise offset for time functionality does not work correctly on partitions with message.timestamp.type = CreateTime if produced via sarama. |
puellanivis
reviewed
Feb 28, 2025
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
I see nothing to comment on.
dnwe
approved these changes
Feb 28, 2025
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to other clients, set the MaxTimestamp computed from the records
in the batch.