Interesting that we’re not getting this flagged by staticcheck in our golangci-lint runs as we definitely have sc enabled here

Interesting that we’re not getting this flagged by staticcheck in our golangci-lint runs as we definitely have sc enabled here

  disable-all: true

This might be related?

  disable-all: true

This might be related?

That’s just the config equivalent of the cli flag to disable all the default linters and only enable explicitly defined ones

Very strange, run via golangci-lint we get no results for staticcheck even if we disable all config and default excludes:

% golangci-lint-1.62.2 run --no-config --disable-all --enable=staticcheck --exclude-use-default=false .

But standalone staticcheck flags a few different things including S1009:

% staticcheck ./...
balance_strategy.go:993:30: func (*partitionMovements).isLinked is unused (U1000)
balance_strategy.go:1028:30: func (*partitionMovements).in is unused (U1000)
balance_strategy.go:1043:30: func (*partitionMovements).hasCycles is unused (U1000)
balance_strategy.go:1075:30: func (*partitionMovements).isSticky is unused (U1000)
balance_strategy.go:1093:6: func indexOfSubList is unused (U1000)
metrics_helpers_test.go:120:6: func minMaxHistogramValidator is unused (U1000)
mocks/async_producer.go:77:7: should omit nil check; len() for []*github.com/IBM/sarama/mocks.producerExpectation is defined as zero (S1009)
mocks/mocks.go:55:41: error strings should not be capitalized (ST1005)
mocks/mocks.go:56:41: error strings should not be capitalized (ST1005)

the staticcheck linter used by golangci-lint isn't the same as the standalone staticcheck tool.
according to golangci-lint's documentation, the author of staticcheck does not approve its use as a library inside golangci-lint.
this could explain why some checks, like S1009, are flagged when running staticcheck directly but not via golangci-lint.

for reference: https://golangci-lint.run/usage/linters/#staticcheck