feat(admin): implement leader election api#3030
Merged
Conversation
Contributor
Author
chengjoey
force-pushed
the
feat/elect-leaders
branch
from
ed2ffd1 to
15b5a1c
Compare
Signed-off-by: joey <[email protected]>
chengjoey
force-pushed
the
feat/elect-leaders
branch
from
15b5a1c to
b7da05f
Compare
Collaborator
|
@chengjoey thanks for submitting this PR! Looking over the changes as a first-pass they generally look good to me. I'd like to re-review the protocol changes alongside the spec and also run a few manual tests myself, but this looks promising. Thanks again |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: #2744
implement leader election api in sarama
elect leaders API