fix: log SASL connection and handshake errors#2995
Merged
Conversation
I'm trying to debug an issue and the logger is only logging: `Error while performing SASL handshake kafka-1:9093` since the actual error is not logged, it's not clear what went wrong. Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
force-pushed
the
SARAMA-2994_log-sasl-conn-err
branch
from
cc68fd5 to
a721a20
Compare
Contributor
Author
puellanivis
reviewed
Oct 1, 2024
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
The calls to .Error() can be dropped for all of the lines of change.
Other than that, everything looks solid.
Signed-off-by: Pierangelo Di Pilato <[email protected]>
puellanivis
reviewed
Oct 2, 2024
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
Looks good now. Just need to confirm that the errors don’t have sensitive info.
dnwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to debug an issue and the logger is only logging:
Error while performing SASL handshake kafka-1:9093since theactual error is not logged, it's not clear what went wrong.
Verified that the error doesn't contain sensitive data
Fixes #2994
Addition reference: #2234 (comment)