Skip to content

feat: update go directive to 1.20#2933

Merged
dnwe merged 1 commit intoIBM:mainfrom
mauri870:hotfix/go-1.20
Aug 13, 2024
Merged

feat: update go directive to 1.20#2933
dnwe merged 1 commit intoIBM:mainfrom
mauri870:hotfix/go-1.20

Conversation

@mauri870
Copy link
Copy Markdown
Contributor

@mauri870 mauri870 commented Jul 4, 2024

The github.com/klauspost/compress recently deprecated go 1.19 and moved to a go 1.20 directive in go.mod

@mauri870
Copy link
Copy Markdown
Contributor Author

mauri870 commented Jul 4, 2024

Wondering why we don't move to a supported go version, such as 1.21 and 1.22?

@dnwe
Copy link
Copy Markdown
Collaborator

dnwe commented Aug 7, 2024

@mauri870 thanks for the PR — a bump to 1.20 is fine to allow us to keep pulling in compress updates. We don't tend to bump the go directive in go.mod further than that until we (or one of our direct dependencies) is using some newer part of the Go language that requires a newer toolchain in order to compile. Whilst Go themselves officially only maintain support for the latest N and N-1 versions, there will be various people using Sarama from Debian stable / Ubuntu LTS / RedHat Enterprise etc. and potentially using the Go toolchain supplied and maintained by the vendor with backported security patches etc.

@dnwe dnwe force-pushed the hotfix/go-1.20 branch 2 times, most recently from e71402f to f363e32 Compare August 12, 2024 18:24
Signed-off-by: Mauri de Souza Meneguzzo <[email protected]>
@dnwe dnwe added the feat label Aug 13, 2024
@dnwe dnwe merged commit 7104aa7 into IBM:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants