fix(client): refactor duplicated replica+partition logic#2925
Merged
Conversation
Contributor
Trinoooo
commented
Jun 11, 2024
Trinoooo
commented
- extract the same logic in Replicas, InSyncReplicas, OfflineReplicas. Improve reusability, maintainability, and consistency
- remove unnecessary local variable and misleading annotion. see Sincerely ask, is this redundant? #2923
dnwe
force-pushed
the
style/eliminate_redundancies_and_misunderstandings
branch
from
a1fb1e9 to
7dc5281
Compare
puellanivis
reviewed
Aug 7, 2024
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
Looks all reasonable to me.
dnwe
force-pushed
the
style/eliminate_redundancies_and_misunderstandings
branch
4 times, most recently
from
18da12b to
fdfd7a4
Compare
dnwe
approved these changes
Aug 13, 2024
dnwe
changed the title
dnwe
changed the title
dnwe
force-pushed
the
style/eliminate_redundancies_and_misunderstandings
branch
from
fdfd7a4 to
496e760
Compare
1. extract the same logic in Replicas, InSyncReplicas, OfflineReplicas. Improve reusability, maintainability, and consistency 2. remove unnecessary local variable and misleading annotation. see IBM#2923 Signed-off-by: Trino <[email protected]>
extract the same logic in Partitions and WritablePartitions Signed-off-by: Trino <[email protected]>
dnwe
force-pushed
the
style/eliminate_redundancies_and_misunderstandings
branch
from
496e760 to
dada7ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.