KIP-368 : Allow SASL Connections to Periodically Re-Authenticate#2197
KIP-368 : Allow SASL Connections to Periodically Re-Authenticate#2197
Conversation
k-wall
force-pushed
the
kip-368
branch
3 times, most recently
from
94a0874 to
88b1c46
Compare
|
The tests that are failing on Go 1.18/Kafka 2.8.1 TestFuncConsumerGroupPartitioningStateful don't appear to be related to my change. |
| } | ||
|
|
||
| func currentUnixMilli() int64 { | ||
| return time.Now().UnixNano() / int64(time.Millisecond) |
There was a problem hiding this comment.
The project aims at supporting the last couple of Golang version, so we could use time.Now().UnixMilli() that was introduced in 1.17. That said, it may be preferable to keep the current code for now to support older environments.
There was a problem hiding this comment.
The project is still on go 1.16, so I cannot adopt this API yet. Also, if I understand the project's "two releases and two months" right it'd be too soon to bump Go right now (1.18 only came out last month (March 2022), so it is too soon for the project to adopt 1.17).
Allow SASL Connections to Periodically Re-Authenticate [KIP-368](https://cwiki.apache.org/confluence/display/KAFKA/KIP-368%3A+Allow+SASL+Connections+to+Periodically+Re-Authenticate)
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Excellent! Thank you for implementing this KIP. LGTM
3 participants
Proposed fix for #2060.
If the server uses KIP-368, the client will cause itself to reauthenticate by emitting the necessary SASL handshake/authenticate with the next client to server interaction.