Add driver full names and qualifying lap time UI#135
Closed
viralcodex wants to merge 1 commit intoIAmTomShaw:mainfrom
Closed
Add driver full names and qualifying lap time UI#135viralcodex wants to merge 1 commit intoIAmTomShaw:mainfrom
viralcodex wants to merge 1 commit intoIAmTomShaw:mainfrom
Conversation
Introduces support for displaying driver full names throughout the replay UI by passing and storing a driver_full_names mapping. Adds a new QualifyingLapTimeComponent to show sector times, tyre info, and deltas in the UI. Updates data flow in main.py, arcade_replay.py, f1_data.py, and race_replay.py to support these features.
Owner
|
I think I prefer the 3 letter abbreviations for the driver names. They're much more like the real broadcast :) |
Contributor
Author
|
Sure @IAmTomShaw , do check the other PRs/issues i have opened and contributed to, thanks and happy new year in advance 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #134
Introduces support for displaying driver full names throughout the replay UI by passing and storing a driver_full_names mapping. Adds a new QualifyingLapTimeComponent to show sector times, tyre info, and deltas in the UI. Updates data flow in main.py, arcade_replay.py, f1_data.py, and race_replay.py to support these features.
@IAmTomShaw , hope this helps 😄