Merge pull request #3189 from Zac-HD/representative-examples

Zac-HD · web-flow · commit e1305ad12143 · 2021-12-12T09:32:20.000+11:00
Representative examples
diff --git a/hypothesis-python/RELEASE.rst b/hypothesis-python/RELEASE.rst
@@ -0,0 +1,5 @@
+RELEASE_TYPE: patch
+
+This patch makes the ``.example()`` method more representative of
+test-time data generation, albeit often at a substantial cost to
+readability (:issue:`3182`).
diff --git a/hypothesis-python/src/hypothesis/strategies/_internal/strategies.py b/hypothesis-python/src/hypothesis/strategies/_internal/strategies.py
@@ -16,7 +16,7 @@
 import sys
 import warnings
 from collections import defaultdict
-from random import choice as random_choice
+from random import shuffle
 from typing import (
     Any,
     Callable,
@@ -315,25 +315,30 @@ def example(self) -> Ex:
                     "#drawing-interactively-in-tests for more details."
                 )
 
+        try:
+            return self.__examples.pop()
+        except (AttributeError, IndexError):
+            self.__examples: List[Ex] = []
+
         from hypothesis.core import given
 
         # Note: this function has a weird name because it might appear in
         # tracebacks, and we want users to know that they can ignore it.
         @given(self)
         @settings(
             database=None,
-            max_examples=10,
+            max_examples=100,
             deadline=None,
             verbosity=Verbosity.quiet,
             phases=(Phase.generate,),
             suppress_health_check=HealthCheck.all(),
         )
         def example_generating_inner_function(ex):
-            examples.append(ex)
+            self.__examples.append(ex)
 
-        examples: List[Ex] = []
         example_generating_inner_function()
-        return random_choice(examples)
+        shuffle(self.__examples)
+        return self.__examples.pop()
 
     def map(self, pack: Callable[[Ex], T]) -> "SearchStrategy[T]":
         """Returns a new strategy that generates values by generating a value
