Add pyright tests parameterized over python versions

Ryan Soklaski · Ryan Soklaski · commit db5ed42b3532 · 2022-06-25T11:32:43.000-04:00
diff --git a/whole-repo-tests/test_pyright.py b/whole-repo-tests/test_pyright.py
@@ -21,6 +21,8 @@
 from hypothesistooling.projects.hypothesispython import HYPOTHESIS_PYTHON, PYTHON_SRC
 from hypothesistooling.scripts import pip_tool, tool_path
 
+PYTHON_VERSIONS = [f"3.{v}" for v in range(7, 11)]
+
 
 @pytest.mark.skip(
     reason="Hypothesis type-annotates the public API as a convenience for users, "
@@ -30,7 +32,8 @@ def test_pyright_passes_on_hypothesis():
     pip_tool("pyright", "--project", HYPOTHESIS_PYTHON)
 
 
-def test_pyright_passes_on_basic_test(tmp_path: Path):
+@pytest.mark.parametrize("python_version", PYTHON_VERSIONS)
+def test_pyright_passes_on_basic_test(tmp_path: Path, python_version: str):
     file = tmp_path / "test.py"
     file.write_text(
         textwrap.dedent(
@@ -51,10 +54,40 @@ def test_bar(x: str):
             """
         )
     )
-    _write_config(tmp_path, {"typeCheckingMode": "strict"})
+    _write_config(
+        tmp_path, {"typeCheckingMode": "strict", "pythonVersion": python_version}
+    )
     assert _get_pyright_errors(file) == []
 
 
+@pytest.mark.parametrize("python_version", PYTHON_VERSIONS)
+def test_given_only_allows_strategies(tmp_path: Path, python_version: str):
+    file = tmp_path / "test.py"
+    file.write_text(
+        textwrap.dedent(
+            """
+            from hypothesis import given
+
+            @given(1)
+            def f():
+                pass
+            """
+        )
+    )
+    _write_config(
+        tmp_path, {"typeCheckingMode": "strict", "pythonVersion": python_version}
+    )
+    assert (
+        sum(
+            e["message"].startswith(
+                'Argument of type "Literal[1]" cannot be assigned to parameter "_given_arguments"'
+            )
+            for e in _get_pyright_errors(file)
+        )
+        == 1
+    )
+
+
 def test_pyright_issue_3296(tmp_path: Path):
     file = tmp_path / "test.py"
     file.write_text(
